Skip to content

feat: nodejs sidecar#39829

Closed
betodealmeida wants to merge 7 commits into
masterfrom
nodejs-sidecar
Closed

feat: nodejs sidecar#39829
betodealmeida wants to merge 7 commits into
masterfrom
nodejs-sidecar

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions Bot added api Related to the REST API plugins packages labels May 2, 2026
@betodealmeida betodealmeida changed the title Nodejs sidecar feat: nodejs sidecar May 2, 2026
Comment thread query-context-sidecar/src/server.ts Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

❌ Patch coverage is 51.45631% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.36%. Comparing base (98eaaaa) to head (285d7b1).
⚠️ Report is 209 commits behind head on master.

Files with missing lines Patch % Lines
superset/charts/data/query_context_sidecar.py 30.95% 28 Missing and 1 partial ⚠️
superset/charts/data/api.py 44.44% 19 Missing and 1 partial ⚠️
superset/commands/chart/create.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #39829      +/-   ##
==========================================
- Coverage   64.37%   64.36%   -0.01%     
==========================================
  Files        2569     2570       +1     
  Lines      134682   134777      +95     
  Branches    31253    31272      +19     
==========================================
+ Hits        86698    86750      +52     
- Misses      46485    46526      +41     
- Partials     1499     1501       +2     
Flag Coverage Δ
hive 39.65% <24.44%> (-0.03%) ⬇️
javascript 66.64% <100.00%> (+<0.01%) ⬆️
mysql 59.91% <44.44%> (-0.01%) ⬇️
postgres 59.99% <44.44%> (-0.01%) ⬇️
presto 41.41% <34.44%> (-0.02%) ⬇️
python 61.52% <44.44%> (-0.02%) ⬇️
sqlite 59.62% <44.44%> (-0.02%) ⬇️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bito-code-review
Copy link
Copy Markdown
Contributor

The CodeQL alert flags a potential security issue in server.ts where user-provided data (like formData.viz_type) is included in error logs and responses, risking information disclosure or injection. To mitigate, avoid exposing user input or internal error details.

query-context-sidecar/src/server.ts

console.error('Error building query context:', err);
    jsonResponse(res, 500, {
      error: 'Failed to build query context',
    });

@github-actions github-actions Bot removed the packages label May 2, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 2, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 77016b3
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69f5f5d53aa4b1000835b0b6
😎 Deploy Preview https://deploy-preview-39829--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants