Skip to content

fix(table): consolidate visual column options under Visual formatting section#39856

Merged
msyavuz merged 1 commit into
masterfrom
msyavuz/fix/table-visual-formatting
May 8, 2026
Merged

fix(table): consolidate visual column options under Visual formatting section#39856
msyavuz merged 1 commit into
masterfrom
msyavuz/fix/table-visual-formatting

Conversation

@msyavuz
Copy link
Copy Markdown
Member

@msyavuz msyavuz commented May 4, 2026

SUMMARY

Move Customize columns under Visual formatting and change naming to make it clear that checkboxes effect all columns instead.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

  1. Create a table chart
  2. Add columns and metrics
  3. Check the Customize tab for the changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…tion

Move the per-column "Customize columns" control into the "Visual formatting"
section so users see that per-column overrides and chart-wide toggles are
related. Rename the chart-wide toggles ("Show cell bars", "Align +/-",
"Add colors to cell bars for +/-") to append "for all columns", clarifying
that they apply globally and not per-column. Applies to both the Table and
Interactive Tables (AG Grid) plugins.
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 4, 2026

Code Review Agent Run #307025

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 06868e8..06868e8
    • superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
    • superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot Bot added change:frontend Requires changing the frontend viz:charts:table Related to the Table chart labels May 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.35%. Comparing base (dc1c0f6) to head (06868e8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #39856   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files        2569     2569           
  Lines      134680   134680           
  Branches    31254    31254           
=======================================
  Hits        86679    86679           
  Misses      46505    46505           
  Partials     1496     1496           
Flag Coverage Δ
javascript 66.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@alexandrusoare alexandrusoare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msyavuz msyavuz merged commit 69fbbfd into master May 8, 2026
75 of 77 checks passed
@msyavuz msyavuz deleted the msyavuz/fix/table-visual-formatting branch May 8, 2026 07:43
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend plugins size/M viz:charts:table Related to the Table chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants