perf(sql-lab): use useDeferredValue for schema browser search

[rusackas]

SUMMARY

Refs #39890. First useDeferredValue adoption following the React 18 upgrade.

Replaces the fixed-delay useDebounceValue with useDeferredValue in TableExploreTree's schema browser search (the recently-debounced search from #39489).

Why useDeferredValue is strictly better here

• No fixed timeout. The deferred update runs as low-priority work and is automatically interrupted on each new keystroke, so the filter never lingers behind the input.
• Input stays responsive because it reads searchTerm directly (line 472 of the file). The expensive tree-filter computation reads deferredSearchTerm instead.
• One fewer custom-hook dependency. Uses the React primitive.

The other useDebounceValue consumers in the codebase (SQL editor auto-save, SQL validation, JS editor parsing) debounce API calls or expensive parsing — not UI filtering — so they stay debounced. They're listed in #39890 for case-by-case follow-up but are not the same pattern.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual change. Behaviorally: typing into the schema-browser search field should feel snappier — the input never lags while the tree filter catches up, because React deprioritizes the filter under typing pressure.

TESTING INSTRUCTIONS

1. Open SQL Lab and pick a database with many schemas/tables.
2. Type into the schema-browser search field rapidly. Input should feel responsive throughout.
3. Filter results should converge after you stop typing — same end state as before.
4. Clearing the field should restore the full tree.
5. npm test -- --testPathPatterns='TableExploreTree' — passes locally (11/11).

ADDITIONAL INFORMATION

• Has associated issue: TODO: Adopt React 18 concurrent features now that the upgrade has landed #39890
• Required feature flags:
• Changes UI
• Includes DB Migration
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #f56d62

Actionable Suggestions - 0

Additional Suggestions - 1

• superset-frontend/src/SqlLab/components/TableExploreTree/index.tsx - 1

  • Performance Regression from Removed Debouncing · Line 21-21
    Replacing useDebounceValue with useDeferredValue removes the 250ms debouncing delay, causing search filtering to occur on every keystroke instead of after the user stops typing. This can lead to performance issues with large tree data, as hasMatchingNodes and searchMatch computations run more frequently. The original debouncing was appropriate for search inputs to avoid excessive re-renders and computations.

Review Details

• Files reviewed - 1 · Commit Range: 5f2e0fb..5f2e0fb

  • superset-frontend/src/SqlLab/components/TableExploreTree/index.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by