fix(tests): prevent SemanticLayerModal test from hanging indefinitely#39956
Closed
aminghadersohi wants to merge 1 commit into
Closed
fix(tests): prevent SemanticLayerModal test from hanging indefinitely#39956aminghadersohi wants to merge 1 commit into
aminghadersohi wants to merge 1 commit into
Conversation
The SemanticLayerModal test called jest.useFakeTimers() which intercepts setTimeout. Because the test environment disables MessageChannel (for rc-overflow compatibility), React 18's scheduler falls back to setTimeout for scheduling re-renders. With fake timers active, React can never re-render, waitFor() can never be satisfied or time out, and the test hangs indefinitely. Fix by passing advanceTimers: true so React's scheduler timers auto-fire while the 500ms debounce remains under explicit control. Also reorder DatasetList.test.tsx afterEach to call jest.useRealTimers() before the async flush, preventing a secondary deadlock if a loading test throws while fake timers are active. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan