fix(explore): remove leftover debug console.log in ZoomConfigControl#39991
Conversation
…pache#39622) Drops a `console.log('now in onbasewidthcahnge')` (note the typo) that was left in `onBaseWidthChange` and fires on every drag of the Base Width slider, polluting the browser console during normal Explore usage. Pure cleanup — no behavior change. Co-Authored-By: Claude Code <noreply@anthropic.com>
Code Review Agent Run #d727f8Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
|
Thanks for the fix! Will merge if/when CI turns green. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39991 +/- ##
=======================================
Coverage 63.83% 63.83%
=======================================
Files 2589 2589
Lines 137821 137820 -1
Branches 31928 31928
=======================================
+ Hits 87978 87979 +1
+ Misses 48327 48325 -2
Partials 1516 1516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SUMMARY
Drops a leftover debug
console.log('now in onbasewidthcahnge')(note the typo) fromonBaseWidthChangeinZoomConfigControl.tsx. The statement fires on every drag of the Base Width slider in the Explore view, polluting the browser console during normal usage. Pure cleanup — no behavior change.Fixes #39622 — Leftover Debug Statement Polluting Console in ZoomConfigControl
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable — the only observable change is the absence of one line in the DevTools console while dragging the Base Width slider.
TESTING INSTRUCTIONS
Reproduce BEFORE/AFTER yourself (copy-paste)
A reviewer can confirm by inspection — only the exact message changes between BEFORE and AFTER.
What I ran locally
grep -n "console\." superset-frontend/src/explore/components/controls/ZoomConfigControl/— confirmed the file no longer has anyconsole.*calls after the change.no-console: 'warn'(noterror), which is why this leftover slipped through CI; this PR does not change that policy.ADDITIONAL INFORMATION
Risk / blast radius
Zero. The removed line was a
console.logwith no surrounding control flow.setBaseWidth(width)and the rest ofonBaseWidthChangeare untouched.PR drafted with assistance from Claude Code. The change was reviewed manually against apache/superset's source. The reproducer block above was used during development; it is the same one a reviewer can paste verbatim.