fix(dashboard): keep native filter dropdown from covering input

[felipegr0ssi]

SUMMARY

Fixes #34135.

Dashboard Value filters previously mounted the select dropdown into the input's parent element. On short viewports or high browser zoom, that relative container can place the dropdown over the trigger field and hide the current input. This changes dashboard filter selects to mount their popup under document.body, while preserving the existing parent-container behavior for the filter config modal and overflow filter menu.

A unit test verifies dashboard select dropdowns are portaled to document.body.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See the linked issue for the before screenshot.

TESTING INSTRUCTIONS

1. Open the example Sales Dashboard.
2. Reduce the browser height or increase browser zoom.
3. Open a dashboard Value filter.
4. Confirm the dropdown no longer overlaps and hides the select input.

Local checks run:

• npx prettier@3.8.3 --check superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
• npx oxlint@1.62.0 --quiet --config superset-frontend/oxlint.json superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx (0 errors)
• git diff --check

ADDITIONAL INFORMATION

• Has associated issue: Dashboard Filter dropdown input obscured on smaller screens views #34135
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #89c17e

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: c4d2ab8..c4d2ab8

  • superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
  • superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by