Skip to content

feat(i18n): add missing Slovak translations#40219

Merged
sfirke merged 1 commit into
apache:masterfrom
davidkopelent:feat/i18n-sk-translations
May 22, 2026
Merged

feat(i18n): add missing Slovak translations#40219
sfirke merged 1 commit into
apache:masterfrom
davidkopelent:feat/i18n-sk-translations

Conversation

@davidkopelent
Copy link
Copy Markdown
Contributor

SUMMARY

Added missing slovakian language translations

TESTING INSTRUCTIONS

Turn on SK lang and check applied phrases

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 18, 2026

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

@dosubot dosubot Bot added the i18n:slovak label May 18, 2026
@github-actions github-actions Bot added the i18n Namespace | Anything related to localization label May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.16%. Comparing base (ac5e8f1) to head (6f9a422).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #40219   +/-   ##
=======================================
  Coverage   64.16%   64.16%           
=======================================
  Files        2591     2591           
  Lines      138283   138283           
  Branches    32083    32083           
=======================================
  Hits        88726    88726           
  Misses      48027    48027           
  Partials     1530     1530           
Flag Coverage Δ
hive 39.44% <ø> (ø)
mysql 59.13% <ø> (ø)
postgres 59.21% <ø> (ø)
presto 41.13% <ø> (ø)
python 60.64% <ø> (ø)
sqlite 58.85% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfirke
Copy link
Copy Markdown
Member

sfirke commented May 18, 2026

Thanks for the improvements!

Can you please get pre-commit checks passing, I see this failure in CI:

 fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing superset/translations/sk/LC_MESSAGES/messages.po

@davidkopelent davidkopelent force-pushed the feat/i18n-sk-translations branch from 2698fe0 to 3ca26c9 Compare May 19, 2026 06:47
@davidkopelent davidkopelent force-pushed the feat/i18n-sk-translations branch from 3ca26c9 to 6f9a422 Compare May 19, 2026 06:47
@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 3ca26c9
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a0c076c68e78d000886ad73
😎 Deploy Preview https://deploy-preview-40219--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@davidkopelent
Copy link
Copy Markdown
Contributor Author

Hi @sfirke, thank you for quick check, I've added a new line at the end of the translation file, so it should pass now.

Copy link
Copy Markdown
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the branch locally and spot checked a few with Kagi Translate. Looks good.

@sfirke sfirke merged commit 5549100 into apache:master May 22, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n:slovak i18n Namespace | Anything related to localization size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants