fix(chart): fix label and description translation on UI and enhance french translations#40229
Conversation
|
Bito Automatic Review Skipped - Large PR |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
40b8ba4 to
f6299a7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40229 +/- ##
==========================================
+ Coverage 64.19% 64.20% +0.01%
==========================================
Files 2592 2592
Lines 139080 139115 +35
Branches 32299 32302 +3
==========================================
+ Hits 89281 89318 +37
+ Misses 48267 48265 -2
Partials 1532 1532
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
216bade to
3c55047
Compare
|
@hainenber Kindly trigger the CI if possible. I managed to update the PR. My understanding is that it should be triggered manually if the PR is updated |
3c55047 to
3fbb69d
Compare
3fbb69d to
85d5981
Compare
85d5981 to
043f020
Compare
|
@rusackas Would it be possible to review this PR ? Also, I do not know why the CI does not trigger automatically : s |
Just a safety thing, so some rando doesn't come along and do dangerous things with CI. Once your first PR is merged, it'll be automatic on your second and subsequent PRs. Reviewing now.... |
|
@AliGouta opened a follow-up PR to this (linked above) if you want to give that a look. Once it's merged, it should be easy to continue sweeping up if needed. |
|
Bito Automatic Review Skipped – PR Already Merged |
SUMMARY
This PR should fix the translation to other languages many static labels and descriptions in the UI.
Fixes SC #40207 Partial UI Translation for Superset Components.
Root cause: Control labels and description(e.g. "Sort ascending") were defined as label: t('...') — strings evaluated at module load time, before the async language pack had finished loading. As a result, Most labels and Description always displayed in English regardless of the selected language.
Fix: Converted to lazy functions: label: () => t('...') — t() is now evaluated at render time, when i18n is already initialized. All controlPanel.ts files across the filter plugins (Select, Range, Time, etc.) were updated accordingly, along with enriched language translations.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before (screen1):

After (screen1):

Before (screen2):

After (screen2):

TESTING INSTRUCTIONS
Building a new image:
docker build --build-arg BUILD_TRANSLATIONS=true -t superset:fix-40207 .
Deploy and run the image
ADDITIONAL INFORMATION
[ X] Has associated issue: 40207
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in #13351)
Migration is atomic, supports rollback & is backwards-compatible
Confirm DB migration upgrade and downgrade tested
Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API