Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] set control default for *showminmax = false #4766

Merged
merged 1 commit into from Apr 6, 2018

Conversation

mistercrunch
Copy link
Member

Let's make the defaults less crowded on the axes by not showing the min
and max values on the axes (bounds)

Let's make the defaults less crowded on the axes by not showing the min
and max values on the axes (bounds)
@codecov-io
Copy link

Codecov Report

Merging #4766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4766   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files         205      205           
  Lines       15401    15401           
  Branches     1183     1183           
=======================================
  Hits        11180    11180           
  Misses       4218     4218           
  Partials        3        3
Impacted Files Coverage Δ
...set/assets/javascripts/explore/stores/controls.jsx 39.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92230b8...e7c3ba8. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo

@mistercrunch mistercrunch merged commit 59cabe7 into apache:master Apr 6, 2018
@mistercrunch mistercrunch deleted the xbounds_default_false branch April 6, 2018 22:46
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
Let's make the defaults less crowded on the axes by not showing the min
and max values on the axes (bounds)
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
Let's make the defaults less crowded on the axes by not showing the min
and max values on the axes (bounds)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
Let's make the defaults less crowded on the axes by not showing the min
and max values on the axes (bounds)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants