Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] when num_period_compare is not set #4799

Merged
merged 1 commit into from Apr 10, 2018

Conversation

mistercrunch
Copy link
Member

Fixing issues where y_axis_format is set and not num_period_compare

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo

Fixing issues where y_axis_format is set and not num_period_compare
@codecov-io
Copy link

Codecov Report

Merging #4799 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4799      +/-   ##
==========================================
- Coverage   72.33%   72.33%   -0.01%     
==========================================
  Files         208      208              
  Lines       15516    15519       +3     
  Branches     1201     1202       +1     
==========================================
+ Hits        11224    11225       +1     
- Misses       4289     4291       +2     
  Partials        3        3
Impacted Files Coverage Δ
...set/assets/javascripts/explore/stores/controls.jsx 38.02% <100%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7a294...733dc5c. Read the comment docs.

@mistercrunch mistercrunch merged commit 14bf45d into apache:master Apr 10, 2018
@mistercrunch mistercrunch deleted the fix_num_period_compare branch April 10, 2018 21:49
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Apr 11, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Apr 12, 2018
Fixing issues where y_axis_format is set and not num_period_compare

(cherry picked from commit 14bf45d)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
Fixing issues where y_axis_format is set and not num_period_compare
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
Fixing issues where y_axis_format is set and not num_period_compare
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
Fixing issues where y_axis_format is set and not num_period_compare
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants