Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Snowflake engine with supported time grains #4882

Merged
merged 2 commits into from Apr 25, 2018
Merged

Implement Snowflake engine with supported time grains #4882

merged 2 commits into from Apr 25, 2018

Conversation

villebro
Copy link
Member

Initial implementation of Snowflake specific engine.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #4882 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4882      +/-   ##
==========================================
+ Coverage   76.96%   76.97%   +<.01%     
==========================================
  Files          44       44              
  Lines        8534     8537       +3     
==========================================
+ Hits         6568     6571       +3     
  Misses       1966     1966
Impacted Files Coverage Δ
superset/db_engine_specs.py 52.15% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ae9ec...498e7cb. Read the comment docs.

@mistercrunch
Copy link
Member

giphy

@mistercrunch mistercrunch merged commit fa3da8c into apache:master Apr 25, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Implement Snowflake engine with supported time grains

* Fix typo in second grain
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
* Implement Snowflake engine with supported time grains

* Fix typo in second grain
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Implement Snowflake engine with supported time grains

* Fix typo in second grain
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants