Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cypress] Update dashboard test to remove 10s timeout #5957

Merged
merged 2 commits into from Sep 27, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 21, 2018

  1. Go to the dashboard and get list of slices first
  2. Define cy.route for each of the slice
  3. Reload the page and wait for all routes defined in step 2.
  4. Verify

@michellethomas @graceguo-supercat

Copy link
Contributor

@michellethomas michellethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo! Thanks LGTM!

@kristw kristw closed this Sep 22, 2018
@kristw kristw reopened this Sep 22, 2018
@kristw kristw closed this Sep 22, 2018
@kristw kristw reopened this Sep 22, 2018
@kristw kristw force-pushed the kristw-fix-dashboard-test branch 2 times, most recently from 15d73fc to 4aed57b Compare September 25, 2018 21:46
@kristw kristw closed this Sep 27, 2018
@kristw kristw reopened this Sep 27, 2018
@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #5957 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5957   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files         393      393           
  Lines       23667    23667           
  Branches     2638     2638           
=======================================
  Hits        15044    15044           
  Misses       8610     8610           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52033cb...2f3d152. Read the comment docs.

@kristw
Copy link
Contributor Author

kristw commented Sep 27, 2018

Finally pass flaky CI

@graceguo-supercat graceguo-supercat merged commit 0cc0996 into apache:master Sep 27, 2018
@kristw kristw deleted the kristw-fix-dashboard-test branch September 27, 2018 18:32
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Fix dashboard test instead of using fixed 10s timeout

* resolve lint issues
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants