[fix][Annotation] Fix override since/until for annotation #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
force-pushed
the
gg-FixAnnotationOverride
branch
from
87e2dd4
to
d68457f
Compare
kristw
approved these changes
Oct 29, 2018
Codecov Report
@@ Coverage Diff @@
## master #6221 +/- ##
=======================================
Coverage 76.87% 76.87%
=======================================
Files 47 47
Lines 9401 9401
=======================================
Hits 7227 7227
Misses 2174 2174Continue to review full report at Codecov.
|
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 30, 2018
(cherry picked from commit 7d6a429)
Merged
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superset allow chart's time range override annotation's time range parameters. here is control's UI:
this feature was broken since recent introducing time_range parameter. This PR is to fix the issue, so that user can customize annotation's time range.
@betodealmeida @michellethomas @kristw @williaster @fabianmenges