Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] minor fix for Superset logger #6922

Merged
merged 1 commit into from Feb 20, 2019

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Feb 20, 2019

Add 2 minor fixes for Superset logger:

  1. call logger before setState (which update state async way)
  2. rename key id to tab_id
  3. rename key editMode to edit_mode
  4. fix log for omnibar.

@kristw @michellethomas

@@ -171,10 +171,10 @@ class Header extends React.PureComponent {
}

toggleEditMode() {
this.props.setEditMode(!this.props.editMode);
this.props.logEvent(LOG_ACTIONS_TOGGLE_EDIT_DASHBOARD, {
editMode: !this.props.editMode,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm should editMode be snake-cased edit_mode?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. thank you 👀 !

@codecov-io
Copy link

Codecov Report

Merging #6922 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6922   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files         421      421           
  Lines       20449    20449           
  Branches     2220     2220           
=======================================
  Hits        13057    13057           
  Misses       7260     7260           
  Partials      132      132
Impacted Files Coverage Δ
...s/src/dashboard/components/gridComponents/Tabs.jsx 67.85% <ø> (ø) ⬆️
...uperset/assets/src/dashboard/components/Header.jsx 39.17% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ec00b...13a06ff. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #6922 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6922      +/-   ##
==========================================
- Coverage   63.87%   63.87%   -0.01%     
==========================================
  Files         422      422              
  Lines       20514    20513       -1     
  Branches     2230     2230              
==========================================
- Hits        13103    13102       -1     
  Misses       7279     7279              
  Partials      132      132
Impacted Files Coverage Δ
...rset/assets/src/dashboard/components/Dashboard.jsx 89.28% <ø> (-0.19%) ⬇️
...s/src/dashboard/components/gridComponents/Tabs.jsx 67.85% <ø> (ø) ⬆️
...uperset/assets/src/dashboard/components/Header.jsx 39.17% <0%> (ø) ⬆️
superset/assets/src/components/OmniContainer.jsx 12.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9523c...505c3dd. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 16f4721 into apache:master Feb 20, 2019
@graceguo-supercat graceguo-supercat deleted the gg-FixLogger branch February 21, 2019 00:29
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants