[dashboard] click tab anchor link #7640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
approved these changes
Jun 3, 2019
| @@ -66,8 +66,7 @@ class AnchorLink extends React.PureComponent { | |||
| } | |||
|
|
|||
| handleClickAnchorLink(ev) { | |||
There was a problem hiding this comment.
Was this not used anywhere before? Odd
Codecov Report
@@ Coverage Diff @@
## master #7640 +/- ##
==========================================
+ Coverage 65.56% 65.57% +<.01%
==========================================
Files 435 435
Lines 21745 21744 -1
Branches 2393 2393
==========================================
Hits 14258 14258
+ Misses 7365 7364 -1
Partials 122 122
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
that referenced
this pull request
Jun 8, 2019
(cherry picked from commit f99ae1a)
6 tasks
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit def4b60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Click on tab's anchor link should not switch tab. it should only show the shorten url pop-up.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
CI and manual test.
ADDITIONAL INFORMATION
REVIEWERS
@michellethomas @etr2460 @kristw @williaster