fix: remove -1,-1 from owners request in charts, dashboards list and propertiesModal #9989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9989 +/- ##
=======================================
Coverage 71.38% 71.38%
=======================================
Files 585 585
Lines 30987 30994 +7
Branches 3267 3270 +3
=======================================
+ Hits 22119 22126 +7
Misses 8757 8757
Partials 111 111
Continue to review full report at Codecov.
|
nytai
changed the title
nytai
commented
Jun 4, 2020
| @@ -114,7 +111,6 @@ function SelectFilter({ | |||
| let result = inputValue ? [] : [clearFilterSelect]; | |||
| // only call fetch once | |||
| // TODO: allow real async search with `inputValue` | |||
| if (optionsCache.current) return optionsCache.current; | |||
| if (fetchSelects) { | |||
| const selectValues = await fetchSelects(inputValue); | |||
nytai
force-pushed
the
tai/fix-negative-page-vals
branch
2 times, most recently
from
6cb85ff
to
bce9ce7
Compare
nytai
force-pushed
the
tai/fix-negative-page-vals
branch
from
bce9ce7
to
257d0d4
Compare
mistercrunch
approved these changes
Jun 4, 2020
6 tasks
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
followup from: #9988
This removes the problematic
LIMIT -1, -1from the request for all owners. Search is implemented however owners fetch will be limited to 25 records as per FAB defaults.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION