Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYNCOPE-871 Linked NumberWidgets to pages #21

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@tmess567
Copy link
Contributor

commented Jun 16, 2016

Added events to NumberWidget that listen to mousedown events and open up the respective pages as discussed in the SYNCOPE-871 issue.

}
} else if (id.equals("totalAny2OrResources")) {
if (icon.equals("ion ion-gear-a")) {
final Triple<UserFormLayoutInfo, GroupFormLayoutInfo, Map<String, AnyObjectFormLayoutInfo>>

This comment has been minimized.

Copy link
@ilgrosso

ilgrosso Jun 16, 2016

Member

This variable is unused, remove.

setResponsePage(Realms.class, pageParameters);
} else if (id.equals("totalAny1OrRoles")) {
if (icon.equals("ion ion-gear-a")) {
final Triple<UserFormLayoutInfo, GroupFormLayoutInfo, Map<String, AnyObjectFormLayoutInfo>>

This comment has been minimized.

Copy link
@ilgrosso

ilgrosso Jun 16, 2016

Member

This variable is unused, remove.

protected void onEvent(final AjaxRequestTarget target) {
List<AnyTypeTO> anyTypeTOs = new AnyTypeRestClient().list();
PageParameters pageParameters = new PageParameters();
if (id.equals("totalUsers")) {

This comment has been minimized.

Copy link
@ilgrosso

ilgrosso Jun 16, 2016

Member

Convert this if / else if into switch.

templates.setTargetObject(realmTO);
templates.toggle(target, true);
}
class RealmConcrete extends Realm {

This comment has been minimized.

Copy link
@ilgrosso

ilgrosso Jun 16, 2016

Member

I don't understand why you have created RealmConcrete instead of putting your additions directly into Realm

@ilgrosso

This comment has been minimized.

Copy link
Member

commented Jun 17, 2016

Please rebase on master: b1626cf has moved AnyTypeComparator into a separate class file.

@tmess567 tmess567 force-pushed the tmess567:SYNCOPE-871 branch 2 times, most recently from 03557ca to 5b0b364 Jun 17, 2016

@tmess567

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2016

Removing AnyTypeComparator definition from NumberWidget now. Please wait before you merge this.

@tmess567 tmess567 force-pushed the tmess567:SYNCOPE-871 branch from 5b0b364 to 43cc77a Jun 17, 2016

@asfgit asfgit closed this in 20681c8 Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.