This repository has been archived by the owner on May 12, 2021. It is now read-only.
TAJO-1099: LogicalPlanner::convertDataType causes NPE in some cases. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Hi @hyunsik Thank you for your contribution. |
babokim
pushed a commit
to babokim/tajo
that referenced
this pull request
Dec 11, 2014
Improve graph / pivot behavior
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, ExprTestBase has not passed through TypeDeterminant in LogicalPlanPreprocessor. So, unit tests haven't caused this problems.
I fixed the bug and modified LogicalPlanPreprocessor to pass TypeDeterminant in LogicalPlanPreprocessor. As a result, even though this patch does not include any unit tests, it is same as all ExprTestBase tests verify this problem.