From 6dafb22b74249bfe94855dcc91ce849f018ba118 Mon Sep 17 00:00:00 2001 From: Jinho Kim Date: Mon, 24 Aug 2015 12:06:25 +0900 Subject: [PATCH] TAJO-1799: Fix incorrect event handler when kill-query failed. --- .../org/apache/tajo/querymaster/QueryMasterTask.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java b/tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java index c6e2b350df..0f089d5294 100644 --- a/tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java +++ b/tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java @@ -37,7 +37,6 @@ import org.apache.tajo.conf.TajoConf; import org.apache.tajo.engine.planner.global.MasterPlan; import org.apache.tajo.engine.query.QueryContext; -import org.apache.tajo.exception.TajoException; import org.apache.tajo.ipc.TajoWorkerProtocol; import org.apache.tajo.master.cluster.WorkerConnectionInfo; import org.apache.tajo.master.event.*; @@ -57,8 +56,6 @@ import org.apache.tajo.storage.Tablespace; import org.apache.tajo.storage.TablespaceManager; import org.apache.tajo.util.TUtil; -import org.apache.tajo.util.metrics.TajoMetrics; -import org.apache.tajo.util.metrics.reporter.MetricsConsoleReporter; import org.apache.tajo.worker.event.NodeResourceDeallocateEvent; import org.apache.tajo.worker.event.NodeResourceEvent; import org.apache.tajo.worker.event.NodeStatusEvent; @@ -70,8 +67,8 @@ import java.util.concurrent.ConcurrentMap; import java.util.concurrent.atomic.AtomicLong; +import static org.apache.tajo.ResourceProtos.TaskFatalErrorReport; import static org.apache.tajo.TajoProtos.QueryState; -import static org.apache.tajo.ResourceProtos.*; public class QueryMasterTask extends CompositeService { private static final Log LOG = LogFactory.getLog(QueryMasterTask.class.getName()); @@ -264,13 +261,13 @@ protected void killTaskAttempt(int workerId, TaskAttemptId taskAttemptId) { tajoWorkerRpcClient.killTaskAttempt(null, taskAttemptId.getProto(), callFuture); if(!callFuture.get().getValue()){ - queryMasterContext.getEventHandler().handle( + getEventHandler().handle( new TaskFatalErrorEvent(taskAttemptId, "Can't kill task :" + taskAttemptId)); } } catch (Exception e) { /* Node RPC failure */ LOG.error(e.getMessage(), e); - queryMasterContext.getEventHandler().handle(new TaskFatalErrorEvent(taskAttemptId, e.getMessage())); + getEventHandler().handle(new TaskFatalErrorEvent(taskAttemptId, e.getMessage())); } }