Skip to content

Remove unused hocon-parser / hoconjs dependencies and type stub from pyright-language-service #5442

@Ma77Ball

Description

@Ma77Ball

Task Summary

Remove the unused hocon-parser integration from pyright-language-service. It is dead code: hoconParser was used in main.ts to parse the Amber HOCON config, but that call was removed in #3150 (when the language server became a standalone microservice) and the leftover import was removed in #3415. The dependency, the type stub, and a sibling hoconjs dependency were never cleaned up.

This came up in #5435, which tried to improve the stub's return type. Since nothing uses it, removing it is the better change.

What to do:

  • Delete pyright-language-service/src/types/hocon-parser.d.ts
  • Remove hocon-parser (line 9) and hoconjs (line 10) from pyright-language-service/package.json
  • Run yarn install in pyright-language-service/ to update yarn.lock

Acceptance criteria:

  • grep -rn "hocon" pyright-language-service/src returns nothing
  • yarn build (or the existing TypeScript build) in pyright-language-service/ still passes

Pointers (where it used to live):

Task Type

  • Refactor / Cleanup
  • DevOps / Deployment / CI
  • Testing / QA
  • Documentation
  • Performance
  • Other

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions