Skip to content

Separate Pyright language server as one micro service#3150

Merged
yunyad merged 12 commits into
masterfrom
yunyad-pyright
Dec 13, 2024
Merged

Separate Pyright language server as one micro service#3150
yunyad merged 12 commits into
masterfrom
yunyad-pyright

Conversation

@yunyad

@yunyad yunyad commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

This PR separates the Pyright language server as an independent microservice. To provide support for both Pyright and PyLSP, we have created a python-language-server.sh script to run the Python language server.

To run the script:
./python-language-server.sh
By default, it will use PyLSP and run on port 3000. To run Pyright, use the following command:
./python-language-server.sh --server=pyright
For example, to run PyLSP on a different port (e.g., 4000):
./python-language-server.sh --server=pylsp --port=4000

Solve #3125

@yunyad yunyad self-assigned this Dec 12, 2024
@yunyad yunyad changed the title separate python language server Separate Pyright language server as one micro service Dec 12, 2024
@yunyad yunyad requested a review from Yicong-Huang December 13, 2024 05:16

@Yicong-Huang Yicong-Huang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left minor comments.

Comment thread core/scripts/pyright-language-server.sh
Comment thread core/pyright-language-server/src/pythonLanguageServerConfig.json Outdated
Comment thread core/scripts/pyright-language-server.sh
Comment thread core/pyright-language-server/src/pythonLanguageServerConfig.json Outdated
@yunyad yunyad merged commit 8b35e8c into master Dec 13, 2024
@yunyad yunyad deleted the yunyad-pyright branch December 13, 2024 23:23
SarahAsad23 pushed a commit to madisonmlin/texera that referenced this pull request May 20, 2026
This PR separates the Pyright language server as an independent
microservice. To provide support for both Pyright and PyLSP, we have
created a python-language-server.sh script to run the Python language
server.

To run the script:
`./python-language-server.sh`
By default, it will use PyLSP and run on port 3000. To run Pyright, use
the following command:
`./python-language-server.sh --server=pyright`
For example, to run PyLSP on a different port (e.g., 4000):
`./python-language-server.sh --server=pylsp --port=4000`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants