fix(build): download protoc matching target arch in image builds#5573
Open
bobbai00 wants to merge 1 commit into
Open
fix(build): download protoc matching target arch in image builds#5573bobbai00 wants to merge 1 commit into
bobbai00 wants to merge 1 commit into
Conversation
The three service Dockerfiles always fetched the linux-x86_64 protoc release, so the build-time proto regeneration failed on ARM64 image builds (protoc: No such file or directory, exit 127). Select the protoc asset (x86_64 / aarch_64) from $(uname -m) so all target platforms build.
Contributor
Author
|
@xuang7 I think this fix needs to be included in release v1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The three service Dockerfiles (
texera-web-application,computing-unit-master,computing-unit-worker) always downloaded thelinux-x86_64protocrelease, so the build-time Python proto regeneration failed on ARM64 image builds withprotoc: No such file or directory(exit 127). This selects theprotocasset by architecture fromuname -m(x86_64/amd64→x86_64,aarch64/arm64→aarch_64, unknown → fail fast), so both platforms build.Any related issues, documentation, discussions?
Closes #5571
How was this PR tested?
linux-aarch_64asset and that the URL the fix builds resolves (HTTP 200).caseselection under/bin/shmapsx86_64/amd64→x86_64,aarch64/arm64→aarch_64, and exits non-zero on an unknown architecture.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8 (1M context)