From 7360f801611c018288a3db73b764d217bfe4c2b1 Mon Sep 17 00:00:00 2001 From: Dharmesh Kakadia Date: Thu, 29 Sep 2016 14:22:24 -0700 Subject: [PATCH] Correct the downloaded ATS dag data location for analyzer hadoop jar /usr/hdp/current/tez-client/tez-job-analyzer-*.jar CriticalPath --dagId=dag_1475171170456_0002_1 --outputDir=tmp/ fails with INFO history.ATSImportTool: Using baseURL=http://headnodehost:8188/ws/v1/timeline, dagId=dag_1475171170456_0002_1, batchSize=100, downloadDir=tmp java.lang.IllegalArgumentException: Zipfile tmp/dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip does not exist at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88) at org.apache.tez.history.parser.ATSFileParser.(ATSFileParser.java:65) at org.apache.tez.analyzer.plugins.TezAnalyzerBase.run(TezAnalyzerBase.java:169) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.main(CriticalPathAnalyzer.java:653) The code is incorrectly expecting it to be in subfolder(dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip). Moving the downloaded data location to the subfolder fixes the issue. This PR corrects the expected path. --- .../java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java | 1 - 1 file changed, 1 deletion(-) diff --git a/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java b/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java index 38254c8508..1549de9f84 100644 --- a/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java +++ b/tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TezAnalyzerBase.java @@ -160,7 +160,6 @@ public int run(String[] args) throws Exception { //Parse ATS data and verify results //Parse downloaded contents file = new File(outputDir - + Path.SEPARATOR + dagId + Path.SEPARATOR + dagId + ".zip"); }