Skip to content
Permalink
Browse files

THRIFT-4506: fix use of assert for correctness in Java SASL negotiation

Client: java
  • Loading branch information...
jeking3 committed Mar 5, 2018
1 parent 9e0c927 commit d973409661f820d80d72c0034d06a12348c8705e
Showing with 1 addition and 3 deletions.
  1. +1 −3 lib/java/src/org/apache/thrift/transport/TSaslTransport.java
@@ -287,16 +287,14 @@ public void open() throws TTransportException {
if (message.status == NegotiationStatus.COMPLETE &&
getRole() == SaslRole.CLIENT) {
LOGGER.debug("{}: All done!", getRole());
break;
continue;
}

sendSaslMessage(sasl.isComplete() ? NegotiationStatus.COMPLETE : NegotiationStatus.OK,
challenge);
}
LOGGER.debug("{}: Main negotiation loop complete", getRole());

assert sasl.isComplete();

// If we're the client, and we're complete, but the server isn't
// complete yet, we need to wait for its response. This will occur
// with ANONYMOUS auth, for example, where we send an initial response

0 comments on commit d973409

Please sign in to comment.
You can’t perform that action at this time.