Skip to content


Subversion checkout URL

You can clone with
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: apache/thrift
head fork: KenMacD/thrift
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 0 commit comments
  • 1 contributor
Commits on Jan 16, 2012
@KenMacD KenMacD Accept eof on json protocol.
File transport still needs to be updated to send this. Then other
third-party transports like socketio and mochiweb need to send this
instead of 'EOF'.
Showing with 2 additions and 0 deletions.
  1. +2 −0  lib/erl/src/thrift_json_protocol.erl
2  lib/erl/src/thrift_json_protocol.erl
@@ -338,6 +338,8 @@ read_all_1(Transport0, IoList) ->
{Transport1, iolist_to_binary(lists:reverse(IoList))};
{ok, Data} -> % character successfully read; read more
read_all_1(Transport1, [Data|IoList]);
+ {error, eof} ->
+ {Transport1, iolist_to_binary(lists:reverse(IoList))};
{error, 'EOF'} -> % we're done
{Transport1, iolist_to_binary(lists:reverse(IoList))}

No commit comments for this range

Something went wrong with that request. Please try again.