New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-4509: use nodejs 8.x from nodesource.com in travis builds #1500

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bananer
Contributor

bananer commented Mar 7, 2018

No description provided.

@jeking3

jeking3 requested changes Mar 7, 2018 edited

This file is no longer used; all travis builds use docker images from build/docker. The xenial image uses node 6.x and the artful one uses 8.x. See build/docker/README.md

@bananer

This comment has been minimized.

Show comment
Hide comment
@bananer

bananer Mar 7, 2018

Contributor

@jeking3 where would the build encounter nodejs 4.2.6 then?

Contributor

bananer commented Mar 7, 2018

@jeking3 where would the build encounter nodejs 4.2.6 then?

@jeking3

This comment has been minimized.

Show comment
Hide comment
@jeking3

jeking3 Mar 7, 2018

Contributor

As of yesterday afternoon 4.x is no longer used.

Due to the dependencies, and due to the fact that node.js 4.x LTS ends next month, I moved the "oldest" make check job to use nodejs 6.x (ubuntu-xenial) and the current one uses 8.x (ubuntu-artful) - this is the one that runs make check, make cross, ubsan, cppcheck, etc.

We still need to modernize the code/test for js and nodejs however.

Contributor

jeking3 commented Mar 7, 2018

As of yesterday afternoon 4.x is no longer used.

Due to the dependencies, and due to the fact that node.js 4.x LTS ends next month, I moved the "oldest" make check job to use nodejs 6.x (ubuntu-xenial) and the current one uses 8.x (ubuntu-artful) - this is the one that runs make check, make cross, ubsan, cppcheck, etc.

We still need to modernize the code/test for js and nodejs however.

@bananer bananer closed this Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment