Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-4659 golang race detected when closing listener socket #1645

Merged
merged 1 commit into from Dec 11, 2018

Conversation

@jgheewala
Copy link
Contributor

@jgheewala jgheewala commented Dec 10, 2018

Some helpful tips for a successful Apache Thrift PR:

  • Did you test your changes locally or using CI in your fork?
    Tested changes locally
  • Is the Apache Jira THRIFT ticket identifier in the PR title?
    Yes
  • Is the Apache Jira THRIFT ticket identifier in the commit message?
    Yes
  • Did you squash your changes to a single commit?
    Yes
  • Are these changes backwards compatible? (please say so in PR description)
  • Do you need to update the language-specific README?

Client: [go]

@dcelasun dcelasun merged commit 2b7365c into apache:master Dec 11, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
hsanjuan pushed a commit to gxed/thrift-go that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants