Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat rust code with rustfmt 1.0 #1646

Merged
merged 1 commit into from Dec 17, 2018
Merged

Conversation

@allengeorge
Copy link
Contributor

@allengeorge allengeorge commented Dec 16, 2018

No functional changes; format code with rustfmt 1.0.

@allengeorge allengeorge merged commit f4b1785 into apache:master Dec 17, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@allengeorge
Copy link
Contributor Author

@allengeorge allengeorge commented Dec 17, 2018

w00t! I can merge pull requests now :)

@allengeorge allengeorge deleted the allengeorge:rustfmt_10 branch Dec 17, 2018
@allengeorge
Copy link
Contributor Author

@allengeorge allengeorge commented Dec 17, 2018

[puzzled] That said, a couple of things:

  1. I'm unsure why master got a merge commit
  2. I have no idea why the author of the merge commit is Allen George <allengeorge@users.noreply.github.com>
@allengeorge
Copy link
Contributor Author

@allengeorge allengeorge commented Dec 17, 2018

Oh. I see.

For (1) it's because I should have squashed and merged. I'm very sorry: I'll do that in the future.

For (2) it's because I had email privacy enabled, so github used a throwaway. I've changed this.

ashetkar pushed a commit to ashetkar/snappy-thrift that referenced this pull request Sep 24, 2020
Reformat rust code with rustfmt 1.0

Client: rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant