From 4dbcadc527dbaee855fee389399cb5ca7ab76ec2 Mon Sep 17 00:00:00 2001 From: Guido de Caso Date: Mon, 10 Nov 2014 14:51:08 -0300 Subject: [PATCH] do not leave the serverSocket_ open if something goes wrong during construction --- lib/java/src/org/apache/thrift/transport/TServerSocket.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/java/src/org/apache/thrift/transport/TServerSocket.java b/lib/java/src/org/apache/thrift/transport/TServerSocket.java index 8345d44970c..7bd87f4bdc0 100644 --- a/lib/java/src/org/apache/thrift/transport/TServerSocket.java +++ b/lib/java/src/org/apache/thrift/transport/TServerSocket.java @@ -105,8 +105,8 @@ public TServerSocket(ServerSocketTransportArgs args) throws TTransportException // Bind to listening port serverSocket_.bind(args.bindAddr, args.backlog); } catch (IOException ioe) { - serverSocket_ = null; - throw new TTransportException("Could not create ServerSocket on address " + args.bindAddr.toString() + "."); + close(); + throw new TTransportException("Could not create ServerSocket on address " + args.bindAddr.toString() + ".", ioe); } }