From e333ecc945b3e1b7d972101c40a53759bbd9e498 Mon Sep 17 00:00:00 2001 From: Rajesh Sharma Date: Sun, 19 Jan 2014 18:58:09 -0800 Subject: [PATCH] Update TSSLServerSocket.h I think it's a bug to declare createSocket with parameters "int socket" while the base class TServerSocket declares the virtual function createSocket with parameters "THRIFT_SOCKET socket" On windows THRIFT_SOCKET resolves to UINT_PTR hence TSSLServerSocket::createSocket function did not get called from the guts. Hence a nasty hanging problem was happening for me while testing ssl feature using official test_server/test_client. I also posted my question at http://stackoverflow.com/questions/21213094/c-thrift-client-not-working-with-ssl-ssl-connect-hangs --- lib/cpp/src/thrift/transport/TSSLServerSocket.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cpp/src/thrift/transport/TSSLServerSocket.h b/lib/cpp/src/thrift/transport/TSSLServerSocket.h index 6d8e6576c25..9f7a2ac69df 100644 --- a/lib/cpp/src/thrift/transport/TSSLServerSocket.h +++ b/lib/cpp/src/thrift/transport/TSSLServerSocket.h @@ -50,7 +50,7 @@ class TSSLServerSocket: public TServerSocket { TSSLServerSocket(int port, int sendTimeout, int recvTimeout, boost::shared_ptr factory); protected: - boost::shared_ptr createSocket(int socket); + boost::shared_ptr createSocket(THRIFT_SOCKET socket); boost::shared_ptr factory_; };