Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support newer ingress apiVersion #14

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

euven
Copy link
Contributor

@euven euven commented Aug 29, 2023

from K8s version 1.22 you can only access the ingress api via the stable networking.k8s.io/v1 API

@euven
Copy link
Contributor Author

euven commented Aug 29, 2023

@lewismc is it possible to backport this to the 1.26 version too?

from K8s version 1.22 you can only access the ingress api via the stable
'networking.k8s.io/v1' API
@euven
Copy link
Contributor Author

euven commented Aug 31, 2023

@lewismc I've made some more changes that'll allow you to backport this to 1.26.

This is ingress template is basically what you get when executing helm create ;)

@euven
Copy link
Contributor Author

euven commented Sep 12, 2023

ping @lewismc - really keen to get this deployed! :)

@euven
Copy link
Contributor Author

euven commented Sep 20, 2023

@lewismc can you at least let us know if this project is dead, so I can fork it for our organisation?

@lewismc
Copy link
Member

lewismc commented Sep 21, 2023

Hi @euven sincere apologies. It is not dead I was on vacation for a month. I apologize.

I am going to work on granting all contributors commit rights to remove myself as the sole point of failure in term of accepting and reviewing incoming contributions. Thanks for your patience and sorry.

I'll review right now, hopefully merge and then make a release.

@lewismc lewismc added the enhancement New feature or request label Sep 21, 2023
@lewismc lewismc merged commit 74c41fb into apache:main Sep 21, 2023
1 check passed
@lewismc
Copy link
Member

lewismc commented Sep 21, 2023

Tested with

  • k3d version v5.4.7
  • k3s version v1.25.6-k3s1 (default)
  • Tika Server 2.9.0.0-full (latest as of writing)
    All good.
    Passes CI checks.

Thank you @euven . Now I can get to work on

  1. Pushing a release and
  2. Getting some of you guys commit right to this repository

@lewismc
Copy link
Member

lewismc commented Sep 21, 2023

@euven I pushed a release to Artifactory for 2.9.0 and 2.9.0-full.
If there's anything else you would like please let me know here.
Thanks

@euven
Copy link
Contributor Author

euven commented Sep 25, 2023

Thank you very much @lewismc and apologies for all the pings while you were away on holiday (hope you enjoyed it!) - glad to hear this project is alive and well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants