Skip to content

Commit 3815b49

Browse files
committed
Fix unwanted JPMS dependency of embed-core on embed-jasper
This wasn't happening with a clean/release build. It was with an incremental build because the embed-jasper JAR was then present when embed-core was processed. Moving these classes, which are only used by Japser, ensures this dependency is not created.
1 parent 5746337 commit 3815b49

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

build.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -745,11 +745,13 @@
745745
<include name="org/apache/tomcat/jni/**" />
746746
<include name="org/apache/jk/**" />
747747
<include name="org/apache/tomcat/util/**" />
748+
<exclude name="org/apache/tomcat/util/descriptor/tld/**" />
748749
</patternset>
749750

750751
<patternset id="files.tomcat-embed-jasper" >
751752
<patternset refid="files.jasper" />
752753
<patternset refid="files.jsp-api" />
754+
<include name="org/apache/tomcat/util/descriptor/tld/**" />
753755
</patternset>
754756

755757
<patternset id="files.tomcat-embed-el" >

res/bnd/tomcat-embed-core.jar.tmp.bnd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ Export-Package: \
6767
org.apache.tomcat.util.compat,\
6868
org.apache.tomcat.util.descriptor,\
6969
org.apache.tomcat.util.descriptor.tagplugin,\
70-
org.apache.tomcat.util.descriptor.tld,\
7170
org.apache.tomcat.util.descriptor.web,\
7271
org.apache.tomcat.util.digester,\
7372
org.apache.tomcat.util.file,\

res/bnd/tomcat-embed-jasper.jar.tmp.bnd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ Export-Package: \
2828
org.apache.jasper.servlet,\
2929
org.apache.jasper.tagplugins.jstl,\
3030
org.apache.jasper.tagplugins.jstl.core,\
31-
org.apache.jasper.util
31+
org.apache.jasper.util,\
32+
org.apache.tomcat.util.descriptor.tld
3233

3334
-includepackage: \
3435
org.apache.jasper.resources

webapps/docs/changelog.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@
7575
<bug>64751</bug>: Correct the JPMS module descriptor so the embedded
7676
JARs may be used with JPMS. (markt)
7777
</fix>
78+
<fix>
79+
When performing an incremental build, ensure bdn does not create
80+
unwanted JPMS dependencies between embedded JARs. (markt)
81+
</fix>
7882
</changelog>
7983
</subsection>
8084
<subsection name="Coyote">

0 commit comments

Comments
 (0)