Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix typo #194
Wow. There are a lot of changes here. Thank you.
It is too much to review in one go. I took a quick look at the first few changes files and things look good. My current plan is to review these in detail commit by commit and cherry-pick each commit once it has been reviewed.
I appreciate that some of these commits may depend on previous commits. That said, more PRs with fewer commits would be easier to work with where that is possible.
I'm about 2/3 of the way through the commits. With the benefit of experience, 1 PR vs multiple PRs doesn't make that much of a difference. What would have helped was re-basing the PR against master. I've done this locally and there were only a couple of conflicts and it makes it much easier to review.
I spotted a few unused i18n strings that weren't removed from the translations. That isn't a big deal as the process we use to import/export to/from POEditor will clean those up.
I have spotted a couple of minor issues. I'll fix those before merging the commits. I'll also comment on the commit in this PR where it makes sense to do so.