Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE in NamingContextListener.getGlobalNamingContext with Embedded containers #201

Closed
wants to merge 1 commit into from

Conversation

@alitokmen
Copy link

commented Sep 8, 2019

When the Service is an Embedded service, it doesn't have a Server object when stopping - Which in turn implies that when one uses a Tomcat Embedded server the getGlobalNamingContext also cannot rely on the Server object being present when shutting down. Add a !null check in order to avoid NPEs and hence a clean shutdown.

…ed containers

When the Service is an Embedded service, it doesn't have a Server object when stopping - Which in turn implies that when one uses a Tomcat Embedded server the getGlobalNamingContext also cannot rely on the Server object being present when shutting down. Add a !null check in order to avoid NPEs.
@markt-asf

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Thanks for the PR. It has been applied (along with a changelog entry) to master, 8.5.x and 7.0.x

@markt-asf markt-asf closed this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.