DefaultServlet - Strip BOM improvements. #418
Closed
+114
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tServlet Added a basic set of tests by subclassing the parametrized DefaultServletEncodingBaseTest
martin-g
approved these changes
May 11, 2021
Feedback from review
Author
|
Moving the PR away from Draft after incorporating feedback |
rmaucher
approved these changes
May 12, 2021
Contributor
|
I have this applied locally along with an update to the documentation and the change log. I also refactored it to use an Enum for the configuration option. |
markt-asf
added a commit
that referenced
this pull request
May 19, 2021
Based on a PR by Jean-Louis Monteiro Also adds support for the <pr> element in the change log
markt-asf
added a commit
that referenced
this pull request
May 19, 2021
Based on a PR by Jean-Louis Monteiro Also adds support for the <pr> element in the change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR mainly to gather feedback from community