Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultServlet - Strip BOM improvements. #418

Closed
wants to merge 3 commits into from

Conversation

jeanouii
Copy link

Draft PR mainly to gather feedback from community

…tServlet

Added a basic set of tests by subclassing the parametrized DefaultServletEncodingBaseTest
@jeanouii jeanouii marked this pull request as ready for review May 11, 2021 17:59
@jeanouii
Copy link
Author

Moving the PR away from Draft after incorporating feedback

@markt-asf
Copy link
Contributor

I have this applied locally along with an update to the documentation and the change log. I also refactored it to use an Enum for the configuration option.
I'll commit it shortly but I want to update the changelog processing first so we can link to PRs as well as BZ issues.

@markt-asf markt-asf closed this in ea00bb5 May 19, 2021
markt-asf added a commit that referenced this pull request May 19, 2021
Based on a PR by Jean-Louis Monteiro
Also adds support for the <pr> element in the change log
markt-asf added a commit that referenced this pull request May 19, 2021
Based on a PR by Jean-Louis Monteiro
Also adds support for the <pr> element in the change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants