New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal fixes to documentation of Context and Host #439
Conversation
rrodewald
commented
Aug 4, 2021
- Documented default value of unpackWARs attribute
- Tagged all boolean values als code
- Punctuation
- Documented default value of unpackWARs attribute - Tagged all boolean values als code - Punctuation
Reviewing...
|
|
To a native English speaker, either one is completely understandable.
"The default value is ___" is slightly more clear, but I would actually
defer to NON-native English speakers because it may be more
understandable to them one way or the other.
I'm happy to listen to the Russian :)
…On 8/4/21 08:26, Robert Rodewald wrote:
Reviewing...
|1. context.xml L187 `s/docBase/<code>docBase</code>/ `as well 2. I
am more used to "The default value is" rather than "The default is".
I wonder what wording is better. Tomcat documentation uses both. |
1. Done
2. I am no native speaker so I do whatever I'm told to do...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#439 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5COWPV5U3WBTC4PVMQA3DT3EWXRANCNFSM5BQVO4NQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
|
If we want to standardize the wording for default values, I would suggest to open a new pull request for this, so that the main purpose of the present pull request (documentation of the default value of unpackWARs) can be considered as done. Here is an incomplete list of wordings found:
|
Thanks for the PR. +1 tp a new PR to make the default wording consistent. |