Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List duplicate locations when failing a deploy due to duplicated fragment names #535

Closed
wants to merge 1 commit into from

Conversation

rolsdorph
Copy link

For complex deployments with many dependencies, it's easy to lose track of exactly which ones are causing trouble. Currently, you need to look inside each of your dependency jars in order to figure out what's wrong - I think this change is a harmless quality-of-life improvement, and that it should apply cleanly to all three release branches.

Caused by: java.lang.IllegalArgumentException: More than one fragment with the name [some-popular-library] was found. 
This is not legal with relative ordering. See section 8.2.2 2c of the Servlet specification for details. 
Consider using absolute ordering. 
(Duplicates found in: [[file:/home/mads/dev/tomcat/output/build/webapps/madswar/WEB-INF/lib/popular-lib-duplicate.jar, file:/home/mads/dev/tomcat/output/build/webapps/madswar/WEB-INF/lib/popular-lib.jar]]).

…ment names

For complex deployments with many dependencies, it's easy to lose track of exactly which ones are causing trouble. Currently you need to look inside each of your dependency jars in order to figure out what's wrong - I believe this change should be a harmless quality-of-life improvement.
@markt-asf
Copy link
Contributor

Thanks for the PR. I like it. I'm probably being over cautious but I'd like to retain backwards compatibility for the existing methods on WebXml - at least up to 10.0.x anyway. Therefore, I'm going to apply this manually with a few tweaks.

markt-asf added a commit that referenced this pull request Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
markt-asf added a commit that referenced this pull request Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
markt-asf added a commit that referenced this pull request Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
markt-asf added a commit that referenced this pull request Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
@markt-asf
Copy link
Contributor

AS per previous comment, merged manually. Thanks very much for the PR.

@markt-asf markt-asf closed this Aug 24, 2022
@rolsdorph rolsdorph deleted the dupli-names branch August 24, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants