JsonAccessLogValve: Add valve for structured logging #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged this with significant modifications. Thanks. |
|
@thomasmey I added support for all subkeyed patterns like request headers (%i), response headers (%o) etc. You might want to have a look and test it. It is now contained in the heads for all supported branches and will probably be released with the may releases. |
|
@rainerjung very nice, many thanks! I just did test the version which landed in 9.0.74 ... I will allocate some time next week and do some tests. As you are also an httpd committer feel free to have a look at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this adds a AccessLogValve which logs to stderr in JSON format.
sadly the existing code is very entagled in this regards, that the AccessLogElement does cover two functions: formatting and value fetching.
I tricked the existing code to output JSON by try to re-use most existing code/functions.
The result doesn't look to bad, but I'm happy to receive some feedback.
I also left in some comments for questions and ideas that came to my mind while coding.
Happy to hear your feedback.