Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
added portOffset attribute to server.xml per BZ-61171 #63
I think more discussion is required on how to approach this. Specifically, when should the offset be applied? What is the impact on getters and setters? For example connector.setPort (getPort ()) should be a NO-OP. What is reported via JMX? There are all sorts of side effects that need to be thought through here else we'll end up creating some very non-intuative behaviour.
@markt-asf I agree, and I was trying to find different options for this in order to initiate a discussion, but the way that Tomcat reads the config files and initializes objects via introspection really limits us here unless there is a major overhaul.
The process is somewhat like this:
Point (3) is point where I took the
At point (1) above the Connector's setPort() is called by the IntrospectionUtils with the values from
Is it even possible/allowed to change the port after initialization?