bz69439 - fix: improper handling of conflicting cache-control directives#777
Closed
Chenjp wants to merge 1 commit into
Closed
bz69439 - fix: improper handling of conflicting cache-control directives#777Chenjp wants to merge 1 commit into
Chenjp wants to merge 1 commit into
Conversation
rfc9111 - 4.2.1 - If directives conflict (e.g., both max-age and no-cache are present), the most restrictive directive should be honored.
Contributor
|
Thanks for the PR. I have applied a fix based on this PR. Removing the cache-control header caching removes a deliberate performance optimisation (and doesn't update the Javadoc to reflect that change either). I opted for the simpler approach of merging multiple headers into a single header in the cache. I also slightly changed the test cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ExpiresFilter pickup the first-added cache-control header as the effective field, cause follow-up directives (like no-store or max-age) to be ignored.
rfc9111 - 4.2.1 - If directives conflict (e.g., both max-age and no-cache are present), the most restrictive directive should be honored.
ExpiresFilter.XHttpServletResponse.