Partial put - enhance content range verification#778
Merged
Conversation
ContentRange - add isValid(), more length check. ContentRange - parse(): make sure the not-null return of parse() is valid. force content-range unit in lowercase internally. TestDefaultServletPut - partial put
Contributor
|
-1 |
Contributor
Author
A Content-Range field value is invalid if it contains a range-resp that has a last-pos value less than its first-pos value, or a complete-length value less than or equal to its last-pos value. |
Contributor
|
Ok, that's correct, the end is also inclusive. |
Contributor
Author
@rmaucher any further comments? |
markt-asf
added a commit
that referenced
this pull request
Nov 27, 2024
* enhance content range verification ContentRange - add isValid(), more length check. ContentRange - parse(): make sure the not-null return of parse() is valid. force content-range unit in lowercase internally. TestDefaultServletPut - partial put * isValid: remove unnecessary condition. --------- Co-authored-by: Mark Thomas <markt@apache.org>
markt-asf
added a commit
that referenced
this pull request
Nov 27, 2024
* enhance content range verification ContentRange - add isValid(), more length check. ContentRange - parse(): make sure the not-null return of parse() is valid. force content-range unit in lowercase internally. TestDefaultServletPut - partial put * isValid: remove unnecessary condition. --------- Co-authored-by: Mark Thomas <markt@apache.org>
markt-asf
added a commit
that referenced
this pull request
Nov 27, 2024
* enhance content range verification ContentRange - add isValid(), more length check. ContentRange - parse(): make sure the not-null return of parse() is valid. force content-range unit in lowercase internally. TestDefaultServletPut - partial put * isValid: remove unnecessary condition. --------- Co-authored-by: Mark Thomas <markt@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per rfc 9110 - 14.4