enhancement: RateLimitFilter - Provides an exact rate limiting mechanism#794
enhancement: RateLimitFilter - Provides an exact rate limiting mechanism#794Chenjp wants to merge 6 commits into
Conversation
you need exact rate limiting and can accept a small decrease in efficiency, ExactRateLimiter may be an alternative option.
Chenjp
changed the title
|
minimize API change. |
|
You can't remove methods from the |
RateLimiter: keep api as stable as possible.
Updated |
markt-asf
left a comment
markt-asf
left a comment
There was a problem hiding this comment.
The PR makes a very large number of unnecessary changes which makes it extremely hard to review. I have already spend multiple hours just reviewing the refactoring of TimeBucketCounter.
I have yet to decide whether I will proceed with applying those changes as a first step towards to implementing the changes proposed in this PR or whether I'll opt to close this PR and request a series of smaller PRs where each PR addresses a single concern and, potentially, breaks larger, related changes into a series of smaller, reviewable commits.
This is preparatory work for PR #794
|
It turns out the |
This is preparatory work for PR #794
This is preparatory work for PR #794
This is preparatory work for PR #794
|
Closing as I believe all points raised in this PR have now been addressed. |
2 participants
smaller PR from #767 .
If you need exact rate limiting and can accept a small decrease in efficiency, ExactRateLimiter may be an alternative option.