for delete failure case, respond with SC_CONFLICT rather than SC_METHOD_NOT_ALLOWED#802
Closed
Chenjp wants to merge 1 commit into
Closed
for delete failure case, respond with SC_CONFLICT rather than SC_METHOD_NOT_ALLOWED#802Chenjp wants to merge 1 commit into
Chenjp wants to merge 1 commit into
Conversation
…OD_NOT_ALLOWED Since allowed methods check has been performed previously, "method not allowed" is not suitable, then switch to 409. Root cause may be insufficient privileges, OS file locking, or already deleted by another concurrent request.
Contributor
|
Changing things just for the sake of it is not a good plan. The return code is acceptable. |
Contributor
Author
|
It’s confusing. |
Contributor
Author
@rmaucher cause inconsistent allowed methods with Options results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since allowed methods check has been performed previously, failure status code switch to 409 / SC_CONFLICT.
Root cause may be insufficient privileges, OS file locking, or already deleted by another concurrent request.