Fix BZ69508 - Javasource generator - explicitly set literal false when call printParams to process jsp include page#803
Closed
Chenjp wants to merge 4 commits intoapache:mainfrom
Closed
Fix BZ69508 - Javasource generator - explicitly set literal false when call printParams to process jsp include page#803Chenjp wants to merge 4 commits intoapache:mainfrom
Chenjp wants to merge 4 commits intoapache:mainfrom
Conversation
In GeneratorVisitor#generateIncludeWithParameters, since we introduce an extra variable urlVariableName to store include page param, then we need explicit specify literal=true when call #printParams.
In GeneratorVisitor#generateIncludeWithParameters, since we introduce an extra variable urlVariableName to store include page param, then we need explicit specify literal=false when call #printParams.
remove unused jsp file.
Contributor
Author
|
@markt-asf @rmaucher Suggest fix the BZ in next release. |
Contributor
|
Tx for the PR. Merged manually so I could make some minor changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GeneratorVisitor#generateIncludeWithParameters, since we introduce an extra variable urlVariableName to store include page param, then we need explicit specify literal=false when call #printParams.