Repository navigation
9.0.x Host-Manager favicon.ico and Manager JSPs - #878
Merged
Merged
Conversation
1. Tomcat Manager is sometimes run on server on which there is no ROOT context, therefore no default favicon is not found. This commits adds the tomcat favicon to the manager webapp directory and references it from the HTML_HEADER_SECTION in Constants.java
improving previous merged apache#876 (commit d6e79d4) as per Konstantin Kolinko suggestions.
Contributor
|
Thanks for this PR. I'll merge into 9.0.x, double check a few things and then forward port. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per Konstantin Kolinko suggestions [1], this pull request aims to correct and improve the previous #876.
[1] https://lists.apache.org/thread/ofxfdjf2jhz9owst0mf1pmk63rmcoz7m