Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Fetching contributors…

Cannot retrieve contributors at this time

141 lines (118 sloc) 6.192 kb
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
See the License for the specific language governing permissions and
limitations under the License.
Apache Tomcat 6.0 Patch Proposals
[ start all new proposals below, under PATCHES PROPOSED. ]
[ New proposals should be added at the end of the list ]
* Fix the maven stuff for the maven repo.
Before it does't find tomcat-juli.jar and the remoteRepository seems broken .
+1: jfclere
-1: fhanik - easier to pass in the root path (lib/bin) to the macro instead of hacking around it
if we remove the SCP auto feature, then there should be something to replace it with
* Fix
Truststores don't have to have passwords
Based on a patch by 'smmwpf54'
+1: markt
-1: jfclere: Doc says it should use keystorePass (
so that would break existing configurations.
markt: It shouldn't break existing configs. JSSE allows trust stores to be
read without providing the password
* Fix
Failure of one connector should not leave some connectors started and some
+1: markt
+0: kkolinko: good, but maybe we should also prevent against starting
those connectors, that failed to initialize, in StandardService#start()?
Also the message name (some generic name, "connector.failed"), vs.
message text ("starting"), vs. what actually happened (initialize()) -
I won't insist on fixing that inconsistency.
* Configure Tomcat to use HttpOnly for session cookies by default
+1: kkolinko
-0: markt - There wasn't consensus previously.
- If you are going to change the default, do it in the code
* Backport a couple of loader fixes and enhancements:
Add property "searchExternalFirst" to WebappLoader:
If set, the external repositories will be searched before
the WEB-INF ones. Default (false) is unchanged behaviour.
Also expose the new property via JMX and document it.
+1: rjung
-1: markt - The new block
if (hasExternalRepositories && searchExternalFirst) {...}
needs to silently swallow CNFE to have same behaviour as previous
Expose the new WebappLoader flag in the VirtualWebappLoader,
but allow alternative name searchVirtualFirst to make it
consistent with the "virtual" terminology.
Now you can decide, whether the virtual paths will
be searched before the webapp or after it.
If searched before, external resources take precendence
over internal ones. Before that change one couldn't overwrite
resources already present in the webapp.
+1: rjung
Respect configurable search order in getURLs().
+1: rjung
* Fix
When ChannelException is thrown, remove listener from channel.
+1: kfujino, kkolinko
Maybe ";" call
has to be replaced with "this.rpcChannel.breakdown();"
Additional patch.
";" call is
replaced with "this.rpcChannel.breakdown();".
+1: kfujino, kkolinko
* Fix
Provide a mechanism for including requests rejected by the CoyoteAdapter in
the standard access log
This is a backport of: r950587, r950809, r951018, r951093, r951447,
r951892, r952295
+1: markt
kkolinko: 1) It would be nice to log requests using the timestamp when it was
received (like HTTPD 2.0+ does), not when it was processed. If that is to be
implemented, an additional parameter will be needed for the log() method in
the AccessLog interface. I suppose that might be "long t1, long t2" instead
of "long time".
2) I see no way to turn off this feature or filter the output.
* Fix
Avoid NPE if client provides no data with a chunked POST request
+1: markt, kkolinko
Jump to Line
Something went wrong with that request. Please try again.