Simple code refactoring. Trying to gain familiarity with the project#426
Merged
Conversation
Synchronizing head and master
Contributor
|
Clean and simple! Merged! |
otaviojava
reviewed
Feb 28, 2019
| public class Resolver extends MavenResolver { | ||
| public InputStream resolve(final String rawLocation) { | ||
| final boolean initialized = SystemInstance.isInitialized(); | ||
| final String MVN_JNDI_PREFIX = "mvn:"; |
Contributor
There was a problem hiding this comment.
@ShermanMarshall @ShermanMarshall
That is a variable name and not a constant, therefore: have to match regular expression '^[a-z][a-zA-Z0-9]*$'
I belive:
final String mvnJNDIPrefix = "mvn:";
Sounds better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested, no conflicts, project builds with both JDK8 and 10. JIRA ticket is https://issues.apache.org/jira/browse/TOMEE-2479