Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Updated profiles and parameters test to clean up parameters better #3100

Merged
dneuman64 merged 2 commits into from
Dec 13, 2018
Merged

Updated profiles and parameters test to clean up parameters better #3100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28196c
Added actual params to profiles
moltzaum Dec 6, 2018
20fc6e6
Updated profile test to delete parameters it generates. Updated param…
moltzaum Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion traffic_ops/testing/api/v14/parameters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func DeleteTestParameter(t *testing.T, pl tc.Parameter) {
}

// Retrieve the Parameter to see if it got deleted
pls, _, err := TOSession.GetParameterByNameAndConfigFile(pl.Name, pl.ConfigFile)
pls, _, err := TOSession.GetParameterByID(pl.ID)
if err != nil {
t.Errorf("error deleting Parameter name: %s\n", err.Error())
}
Expand Down
5 changes: 3 additions & 2 deletions traffic_ops/testing/api/v14/profiles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,11 @@ func DeleteTestProfiles(t *testing.T) {
t.Errorf("cannot GET Profile by id: %v - %v\n", err, resp)
}
// delete any profile_parameter associations first
// the parameter is what's being deleted, but the delete is cascaded to profile_parameter
for _, param := range resp[0].Parameters {
_, _, err := TOSession.DeleteParameterByProfileParameter(profileID, *param.ID)
_, _, err := TOSession.DeleteParameterByID(*param.ID)
if err != nil {
t.Errorf("cannot DELETE profile_parameter with profileID %d, parameterID %d: %s\n", profileID, *param.ID, err.Error())
t.Errorf("cannot DELETE parameter with parameterID %d: %s\n", *param.ID, err.Error())
}
}
delResp, _, err := TOSession.DeleteProfileByID(profileID)
Expand Down
Loading