Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix Test cg bad login expecting nil err#3102

Merged
rawlinp merged 1 commit into
apache:masterfrom
rob05c:test-fix-cg-badlogin
Dec 6, 2018
Merged

Fix Test cg bad login expecting nil err#3102
rawlinp merged 1 commit into
apache:masterfrom
rob05c:test-fix-cg-badlogin

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Dec 6, 2018

Test was backwards, testing a login failure was expecting a nil err,
needs to expect an error and not a nil for a bad login.

What does this PR do?

Fixes #(issue_number)

Which TC components are affected by this PR?

  • Documentation
  • Grove
  • Traffic Analytics
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • Other _________

What is the best way to verify this PR?

Check all that apply

  • This PR includes tests
  • This PR includes documentation updates
  • This PR includes an update to CHANGELOG.md
  • This PR includes all required license headers
  • This PR includes a database migration (ensure that migration sequence is correct)
  • This PR fixes a serious security flaw. Read more: www.apache.org/security

Test was backwards, testing a login failure was expecting a nil err,
needs to expect an error and not a nil for a bad login.
@rob05c rob05c added the tests related to tests and/or testing infrastructure label Dec 6, 2018
@rawlinp rawlinp merged commit 3431cc9 into apache:master Dec 6, 2018
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Dec 7, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2915/
Test FAILed.

@rob05c rob05c deleted the test-fix-cg-badlogin branch January 2, 2019 20:04
@zrhoffman zrhoffman added the authentication Relating to login, registration, passwords, tokens, etc. label Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

authentication Relating to login, registration, passwords, tokens, etc. tests related to tests and/or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants