Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Rewrite POST servercheck to GO#3935

Merged
ocket8888 merged 9 commits into
apache:masterfrom
mhoppa:feature/rewrite_servercheck
Oct 3, 2019
Merged

Rewrite POST servercheck to GO#3935
ocket8888 merged 9 commits into
apache:masterfrom
mhoppa:feature/rewrite_servercheck

Conversation

@mhoppa

@mhoppa mhoppa commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Build TO with PR changes and use the servercheck POST to create serverchecks. It should have the same behavior as it did before

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • This PR doesn not include an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@asf-ci

asf-ci commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4304/
Test FAILed.

@mhoppa

mhoppa commented Sep 24, 2019

Copy link
Copy Markdown
Contributor Author

retest this please

@asf-ci

asf-ci commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4305/
Test FAILed.

@asf-ci

asf-ci commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4306/
Test PASSed.

@mitchell852 mitchell852 added the Traffic Ops related to Traffic Ops label Sep 25, 2019
@mitchell852 mitchell852 added this to the Go Rewrite milestone Sep 25, 2019
@mitchell852 mitchell852 added tech debt rework due to choosing easy/limited solution TO Client (Go) related to the Go implementation of a TC client documentation related to documentation labels Sep 25, 2019
ocket8888
ocket8888 suggested changes Sep 25, 2019
View reviewed changes
Comment thread lib/go-tc/serverchecks.go
Comment thread docs/source/api/servercheck.rst Outdated
Comment thread traffic_ops/client/toextension.go Outdated
Comment thread traffic_ops/client/toextension.go Outdated
Comment thread traffic_ops/client/toextension.go Outdated
Comment thread lib/go-tc/toextension.go Outdated
Comment thread traffic_ops/testing/api/v14/serverchecks_test.go Outdated
Comment thread traffic_ops/testing/api/v14/serverchecks_test.go Outdated
Comment thread traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go Outdated
Comment thread traffic_ops/traffic_ops_golang/servercheck/servercheck.go Outdated
mhoppa
mhoppa commented Sep 25, 2019
View reviewed changes

@mhoppa mhoppa left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow on commit coming to address comments

Comment thread lib/go-tc/serverchecks.go
Comment thread lib/go-tc/toextension.go Outdated
Comment thread traffic_ops/client/toextension.go Outdated
Comment thread traffic_ops/client/toextension.go Outdated
Comment thread traffic_ops/testing/api/v14/serverchecks_test.go Outdated
Comment thread traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go Outdated
@mhoppa mhoppa force-pushed the feature/rewrite_servercheck branch from 52760f4 to 36cd42b Compare September 26, 2019 15:54
@asf-ci

asf-ci commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4316/
Test PASSed.

@asf-ci

asf-ci commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4317/
Test PASSed.

@asf-ci

asf-ci commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4318/
Test PASSed.

ocket8888
ocket8888 suggested changes Oct 2, 2019
View reviewed changes
Comment thread traffic_ops/testing/api/v14/serverchecks_test.go Outdated
Comment thread traffic_ops/testing/api/v14/serverchecks_test.go Outdated
@asf-ci

asf-ci commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4382/

@asf-ci

asf-ci commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4384/

@asf-ci

asf-ci commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4387/

ocket8888
ocket8888 approved these changes Oct 3, 2019
View reviewed changes

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, well documented, tests pass

@ocket8888 ocket8888 merged commit ccff78a into apache:master Oct 3, 2019
@mhoppa mhoppa deleted the feature/rewrite_servercheck branch October 3, 2019 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ocket8888 ocket8888 ocket8888 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation related to documentation tech debt rework due to choosing easy/limited solution TO Client (Go) related to the Go implementation of a TC client Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

Go Rewrite

Development

Successfully merging this pull request may close these issues.

Rewrite /servercheck to Go

4 participants

@mhoppa @asf-ci @ocket8888 @mitchell852